This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
SocketOutput Allocation Reductions #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with the separate pool for |
| @@ -492,7 +536,12 @@ public void DoShutdownIfNeeded() | |||
| /// </summary> | |||
| public void DoDisconnectIfNeeded() | |||
| { | |||
| if (SocketDisconnect == false || Self._socket.IsClosed) | |||
| if (SocketDisconnect == false) | |||
There was a problem hiding this comment.
I think this can be changed back.
benaadams
force-pushed
the
pool-writecontexts
branch
from
9ed2b85 to
b44f0cf
Compare
|
Closed the other issue, made the changes, rebased |
Without waiting for next libuv pass Fix for potential regression in aspnet#363 due to bug fix.
- This allows all connections accepted by the same thread to share a pool
benaadams
force-pushed
the
pool-writecontexts
branch
from
b44f0cf to
5665eba
Compare
This was referenced Dec 11, 2015
Closed
|
Following on... Can pool the WriteContexts per thread rather than per connection "Pool WriteContext per thread" #469 |
|
Done! Thanks for your patience @benaadams. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of "Resuse writes, initalize queues" #363
Resolves #165 Pool UvWriteReq objects
Resolves #289 High Allocator DoWriteIfNeeded
Resolves #290 High Allocator SocketOutput.Write