Implement support for "fileMappings" #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| errors ??= []; | ||
| string libraryId = LibraryNamingScheme.GetLibraryId(desiredState.Name, desiredState.Version); | ||
| errors.Add(PredefinedErrors.DestinationNotSpecified(libraryId)); |
There was a problem hiding this comment.
Is there a case for v1 manifests where (if they followed the schema) they could encounter this error?
There was a problem hiding this comment.
The v1 schema was declared such that either a defaultDestination must be set, or every library must set a destination. But it got too complicated to be oneOf (defaultDestination, or every library sets a destination, or (every library without fileMappings sets a destination or every fileMapping under a library without a destination includes a fileMapping destination)).
I updated the schema to draft-07 (the newest VS supports) in order to use the if-else logic. This allows VS to detect that fileMappings are used and then apply a validation error that `"version"` must be set to 3.0. (Trying to do it with an anyOf like for destination/defaultDestination would give a fairly ambiguous message instead.)
This becomes the default value for newly created libman.json files (so they will automatically get new feature support like fileMappings).
phil-allen-msft
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
This implements #738. There will be an additional PR to make the JSON completion in the editor work for fileMappings.