This repository has been archived by the owner on Nov 29, 2018. It is now read-only.
Change culture fallback to depth-first #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Trim the trailing section from the culture name, e.g. "fr-FR" becomes "fr" | ||
| var parentCultureName = cultureName.Substring(0, lastIndexOfHyphen); | ||
|
|
||
| culture = GetCultureInfo(parentCultureName, supportedCultures, fallbackToAncestorCulture, currentDepth + 1); |
There was a problem hiding this comment.
Definitely a lot cleaner this way.
|
This looks pretty good, the only thing I might say is that we could note on the Fallback option doc-comment that this is "best effort" and won't ALWAYS give you every possible parent. Otherwise I'd say |
DamianEdwards
force-pushed
the
damianedwards/culture-fallback
branch
2 times, most recently
from
bbd197e
to
b041a07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to some folks we think depth-first is a better approach here (i.e. more useful).
@lodejard @ryanbrandenburg @rynowak @miloush
#112