Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Cache the walking of the CultureInfo tree in ResourceManagerStringLocalizer #20

Closed
wants to merge 6 commits into from

Conversation

DamianEdwards
Copy link
Member

Implemented caching of the walk of the CultureInfo tree to get resource names. Includes tests.
#15

@davidfowl @Eilon @muratg


using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("Microsoft.Framework.Localization.Test")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what @davidfowl thinks, but in some of the projects, we moved Internal classes to an .Internal namespace and made them public for testability instead. We don't seem to be following this on all projects, so just something to think about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's just an internal method to clear a global static cache, not types.

@muratg
Copy link

muratg commented May 19, 2015

Looks good, :shipit:

@hishamco
Copy link
Contributor

@DamianEdwards for better organization, can we introduce an interface named IResourceCache that resource cache adapters have to implement

@DamianEdwards
Copy link
Member Author

@hishamco This isn't something that should be abstracted. It's an implementation detail of this specific IStringLocalizer. It doesn't make sense to create a provider/adapter model here.

- Introduced AssemblyWrapper to enable testing
- Cleaned up properties on ResourceManagerStringLocalizer
- #15
@DamianEdwards
Copy link
Member Author

Merged in 9384848

@DamianEdwards DamianEdwards deleted the damian/CacheCultureWalk branch December 12, 2015 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants