Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Enable file scoped extensible directives #1376

Closed
NTaylorMullen opened this issue May 22, 2017 · 1 comment
Closed

Enable file scoped extensible directives #1376

NTaylorMullen opened this issue May 22, 2017 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@NTaylorMullen
Copy link
Member

These directives would be top-level scoped, one per file, would have overriding behavior implemented by lowering (like @model)
This was referenced May 22, 2017
Closed
Merged
@rynowak rynowak added this to the 2.0.0-preview3 milestone May 30, 2017
@NTaylorMullen NTaylorMullen self-assigned this Jun 12, 2017
@NTaylorMullen NTaylorMullen mentioned this issue Jun 13, 2017
Closed
NTaylorMullen added a commit that referenced this issue Jun 21, 2017
@NTaylorMullen
Add file scoped extensible directives.
714e045 
- Added `DirectiveUsage` to enable extensible directive authors to indicate how their directives should be used. Currently support `Unrestricted` (how section directives have always worked and a single pre-content based directive.
- Added directive parsing tests.
- Removed no longer used `BlockKindInternal` items.

#1376
NTaylorMullen added a commit that referenced this issue Jun 21, 2017
@NTaylorMullen
Update built-in directives to use DirectiveUsage.
033fbd4 
- Updated integration code gen and IR bits to reflect new directive usage.
- Updated existing unit tests that happened to test directives in code blocks to now test what happens when they exist at the document level. Being inside of a code block is now invalid and we have separate tests for that scenario.

#1376
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Update built-in directives to use DirectiveUsage.
74df4a7 
- Updated integration code gen and IR bits to reflect new directive usage.
- Updated existing unit tests that happened to test directives in code blocks to now test what happens when they exist at the document level. Being inside of a code block is now invalid and we have separate tests for that scenario.

#1376
@NTaylorMullen NTaylorMullen mentioned this issue Jun 22, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Update built-in directives to use DirectiveUsage.
a6117b6 
- Updated integration code gen and IR bits to reflect new directive usage.
- Updated existing unit tests that happened to test directives in code blocks to now test what happens when they exist at the document level. Being inside of a code block is now invalid and we have separate tests for that scenario.

#1376
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Add file scoped extensible directives.
1877a29 
- Added `DirectiveUsage` to enable extensible directive authors to indicate how their directives should be used. Currently support `Unrestricted` (how section directives have always worked) and a file scoped singly occurring directive.
- Added directive parsing tests.
- Removed no longer used `BlockKindInternal` items.

#1376
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Update built-in directives to use DirectiveUsage.
1dd4feb 
- Updated integration code gen and IR bits to reflect new directive usage.
- Updated existing unit tests that happened to test directives in code blocks to now test what happens when they exist at the document level. Being inside of a code block is now invalid and we have separate tests for that scenario.

#1376
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Add file scoped extensible directives.
2453689 
- Added `DirectiveUsage` to enable extensible directive authors to indicate how their directives should be used. Currently support `Unrestricted` (how section directives have always worked) and a file scoped singly occurring directive.
- Added directive parsing tests.
- Removed no longer used `BlockKindInternal` items.

#1376
NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Update built-in directives to use DirectiveUsage.
7a04e35 
- Updated integration code gen and IR bits to reflect new directive usage.
- Updated existing unit tests that happened to test directives in code blocks to now test what happens when they exist at the document level. Being inside of a code block is now invalid and we have separate tests for that scenario.

#1376
@NTaylorMullen
Copy link
Member Author

NTaylorMullen commented Jun 22, 2017 •
edited
Loading

1877a29
1dd4feb
6bbcbc1
09ac126

NTaylorMullen added a commit that referenced this issue Jun 22, 2017
@NTaylorMullen
Move seen directives to the parser context.
6bbcbc1 
- The context is guaranteed to be re-created per-parse, it should own the seen directives.

#1376
NTaylorMullen added a commit that referenced this issue Jun 24, 2017
@NTaylorMullen
Make single line single file scoped directives automatically import.
f79e663 
- Added an inner pass inside of the intermediate lowering phase to determine which directives get flowed to the final document. There were many ways to accomplish this but in order to keep the last wins mechanic for non-auto imported directives I had to let the directives get created and then removed based on if they were inherited.
- Added error case if a user attempts to import a block directive with a `FileScopedSinglyOccurring` directive usage.
- Added test cases that validate directives are properly inherietd at the intermediate lowering phase.
- Updated a few tests that had incorrect assumptions.
- Left the default directive passes alone in regards to determining the "imported" directive to enable users to add their own model, inherits, etc. directives that take precedence.
- Normalized the passes in the intermediate lowering phase to handle directives identically (we don't conditionally lower anymore).

#1376
NTaylorMullen added a commit that referenced this issue Jun 24, 2017
@NTaylorMullen
Make single line single file scoped directives automatically import.
b4c2982 
- Added an inner pass inside of the intermediate lowering phase to determine which directives get flowed to the final document. There were many ways to accomplish this but in order to keep the last wins mechanic for non-auto imported directives I had to let the directives get created and then removed based on if they were inherited.
- Added error case if a user attempts to import a block directive with a `FileScopedSinglyOccurring` directive usage.
- Added test cases that validate directives are properly inherietd at the intermediate lowering phase.
- Updated a few tests that had incorrect assumptions.
- Left the default directive passes alone in regards to determining the "imported" directive to enable users to add their own model, inherits, etc. directives that take precedence.
- Normalized the passes in the intermediate lowering phase to handle directives identically (we don't conditionally lower anymore).

#1376
@NTaylorMullen NTaylorMullen mentioned this issue Jun 24, 2017
Merged
NTaylorMullen added a commit that referenced this issue Jun 26, 2017
@NTaylorMullen
Make single line single file scoped directives automatically import.
8cb0e34 
- Added an inner pass inside of the intermediate lowering phase to determine which directives get flowed to the final document. There were many ways to accomplish this but in order to keep the last wins mechanic for non-auto imported directives I had to let the directives get created and then removed based on if they were inherited.
- Added error case if a user attempts to import a block directive with a `FileScopedSinglyOccurring` directive usage.
- Added test cases that validate directives are properly inherietd at the intermediate lowering phase.
- Updated a few tests that had incorrect assumptions.
- Left the default directive passes alone in regards to determining the "imported" directive to enable users to add their own model, inherits, etc. directives that take precedence.
- Normalized the passes in the intermediate lowering phase to handle directives identically (we don't conditionally lower anymore).

#1376
NTaylorMullen added a commit that referenced this issue Jun 26, 2017
@NTaylorMullen
Make single line single file scoped directives automatically import.
d29188a 
- Added an inner pass inside of the intermediate lowering phase to determine which directives get flowed to the final document. There were many ways to accomplish this but in order to keep the last wins mechanic for non-auto imported directives I had to let the directives get created and then removed based on if they were inherited.
- Added error case if a user attempts to import a block directive with a `FileScopedSinglyOccurring` directive usage.
- Added test cases that validate directives are properly inherited at the intermediate lowering phase.
- Updated a few tests that had incorrect assumptions.
- Left the default directive passes alone in regards to determining the "imported" directive to enable users to add their own model, inherits, etc. directives that take precedence.
- Normalized the passes in the intermediate lowering phase to handle directives identically (we don't conditionally lower anymore).

#1376
NTaylorMullen added a commit that referenced this issue Jun 26, 2017
@NTaylorMullen
Make single line single file scoped directives automatically import.
09ac126 
- Added an inner pass inside of the intermediate lowering phase to determine which directives get flowed to the final document. There were many ways to accomplish this but in order to keep the last wins mechanic for non-auto imported directives I had to let the directives get created and then removed based on if they were inherited.
- Added error case if a user attempts to import a block directive with a `FileScopedSinglyOccurring` directive usage.
- Added test cases that validate directives are properly inherited at the intermediate lowering phase.
- Updated a few tests that had incorrect assumptions.
- Left the default directive passes alone in regards to determining the "imported" directive to enable users to add their own model, inherits, etc. directives that take precedence.
- Normalized the passes in the intermediate lowering phase to handle directives identically (we don't conditionally lower anymore).

#1376
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@rynowak @NTaylorMullen