This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
[TS] Reject handshake if connection closes before response #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Sep 22, 2018
| try { | ||
| let startCompleted = false; | ||
| const startPromise = hubConnection.start().then(() => startCompleted = true); | ||
| expect(startCompleted).toBe(false); |
There was a problem hiding this comment.
Shouldn't this be asserted after the await?
There was a problem hiding this comment.
No, it's asserting that startCompleted is false. It will be true after the await. This is to ensure that the promise doesn't complete until the handshake is received.
|
|
@dotnet-bot test Windows Release x64 Build |
analogrelay
reviewed
Sep 24, 2018
| "@types/node": "^8.5.2", | ||
| "@types/webpack": "^4.4.0", | ||
| "jest": "^22.4.3", | ||
| "jest": "^23.6.0", |
There was a problem hiding this comment.
FYI @Eilon. Updated devDependencies (internal use only, not distributed)
davidfowl
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Jest reference because I was finding it impossible to debug a test failure and found similar issues filed against Jest that have been fixed in 23.X.X. Side-effect is rejects.toThrow no longer works in some of our tests because of another bug jestjs/jest#6675. I can revert the Jest change if we want now that I fixed the test.