This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Use IHostingEnvironment.WebRoot as the default static files root. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| internal static string ResolveRootPath(string webRoot, PathString path) | ||
| { | ||
| return Path.GetFullPath(Path.Combine(webRoot, "." + path.Value)); |
|
Updated. |
|
|
||
| internal static string ResolveRootPath(string webRoot, PathString path) | ||
| { | ||
| return Path.GetFullPath(Path.Combine(webRoot, path.Value ?? string.Empty)); |
There was a problem hiding this comment.
Won't the request path have slashes going the wrong way? Does Path.Combine fix that?
There was a problem hiding this comment.
GetFullPath fixes that.
There was a problem hiding this comment.
Ok, we should verify this on mono as well. /cc @Praburaj
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8
Use NotNull.
Use DI to create the middleware (and inject IHostingEnvironment).