This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
Include symbols in sharedfx #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What is the debugger experience in VS like with these symbols present? |
JunTaoLuo
force-pushed
the
johluo/symbols-in-sharedfx
branch
from
c62709b
to
840c818
Compare
natemcmaster
reviewed
Feb 2, 2018
| </ItemGroup> | ||
|
|
||
| <!-- Create symbols archive --> | ||
| <ZipArchive | ||
| File="$(SharedFxOutputPath)$(SharedFxInstallerName)-symbols-$(PackageVersion)-$(SharedFxRID).zip" |
There was a problem hiding this comment.
Can you also update publish settings since we won't be producing this anymore?
Universe/build/Publish.targets
Lines 58 to 74 in 864ee50
There was a problem hiding this comment.
This too:
Lines 29 to 31 in 91b8521
There was a problem hiding this comment.
Updated. I'm updating my VS to test out the debugging experience.
JunTaoLuo
force-pushed
the
johluo/symbols-in-sharedfx
branch
from
e21d2a4
to
2809c17
Compare
|
No longer needed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #131. The aspnetcore shared framework now includes .ni.pdbs produced by crossgen. Note that on linux this will produce .map and on osx there are no debug symbols available after crossgen'ing