Apply monitoringlinter

Apply monitoringlinter, which is designed to enforce
kubevirt/community#219 by ensuring that monitoring-related practices are
implemented within the pkg/monitoring directory using
operator-observability methods.

Signed-off-by: assafad <aadmi@redhat.com>

Makefile

@@ -77,6 +77,10 @@ test:
 lint-metrics:
 	./hack/prom_metric_linter.sh --operator-name="kubevirt" --sub-operator-name="hpp"
 
+lint-monitoring:
+	go install github.com/kubevirt/monitoring/monitoringlinter/cmd/monitoringlinter@e2be790
+	monitoringlinter ./...
+
 generate-doc: build-docgen
 	_out/metricsdocs > docs/metrics.md
 

hack/run-unit-tests.sh

@@ -20,6 +20,7 @@ source "${script_dir}"/common.sh
 go version
 # Validate
 make lint-metrics
+make lint-monitoring
 make generate-doc
 git difftool -y --trust-exit-code --extcmd=./hack/diff-csv.sh