-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(snapbox): Changes to normalization #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Aug 15, 2022
epage
reviewed
Aug 15, 2022
Muscraft
force-pushed
the
data-format-support
branch
3 times, most recently
from
August 16, 2022 21:14
849cff3
to
01338ca
Compare
epage
reviewed
Aug 16, 2022
Muscraft
force-pushed
the
data-format-support
branch
from
August 17, 2022 14:12
01338ca
to
1d5cc1c
Compare
epage
reviewed
Aug 17, 2022
epage
reviewed
Aug 17, 2022
epage
reviewed
Aug 17, 2022
Rename `map_text` to `normalize` Make `normalize` take in a normalization operation
Muscraft
force-pushed
the
data-format-support
branch
from
August 17, 2022 17:31
1d5cc1c
to
be89503
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #92.
This PR is to help move forward the effort with supporting structured data formats. Part of this effort showed that there needed to be a better way to specify what normalization operation was wanted and later to unify what the operations are doing.
map_text
calls asnormalize
with operation typesas_str
totry_string
and update its return to beOption<String>
as_str
was for outputting Diffs. This had to be changed toString
since there are some formats that have borrowing issues with&str
. By changing toString
it allows support for more formats