Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): Take redactions into account for Array elides #358

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Aug 14, 2024

Verified this against cargo in rewriting some tests

Fixes #352

@epage epage enabled auto-merge August 14, 2024 21:12
@epage epage merged commit e230a1d into assert-rs:main Aug 14, 2024
14 of 15 checks passed
@epage epage deleted the elide branch August 14, 2024 21:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10395049619

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.251%

Totals Coverage Status
Change from base Build 10303311497: 0.0%
Covered Lines: 1393
Relevant Lines: 2718

💛 - Coveralls

epage added a commit to epage/snapbox that referenced this pull request Oct 4, 2024
We fixed this for the ordered case in assert-rs#358 but missed the unordered
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json/jsonlines globs are too strict, preventing emulating "contains" tests
2 participants