log and key fallback added if not prod #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fawaz-ahmed
reviewed
Jun 13, 2022
fawaz-ahmed
reviewed
Jun 13, 2022
fawaz-ahmed
reviewed
Jun 13, 2022
There was a problem hiding this comment.
@ali-718 for this logic dont use acEnv, instead use process.env.NODE_ENV
fawaz-ahmed
approved these changes
Jun 14, 2022
assetcrush
reviewed
Jun 14, 2022
example/src/modules/ImageCrush.js
Outdated
| let headers = {}; | ||
|
|
||
| if (process.env.NODE_ENV === "development" && key === '') { |
There was a problem hiding this comment.
this condition will always fail since key will always have a value in development env. Use:
if (process.env.NODE_ENV === "development" && !getKey()) {
fawaz-ahmed
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.