properly reset BUILD_SHARED in deps

assignUser · Sep 6, 2024 · 2cf2674 · 2cf2674
1 parent 95f9ba8
commit 2cf2674
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CMake/resolve_dependency_modules/cpr.cmake b/CMake/resolve_dependency_modules/cpr.cmake
@@ -44,3 +44,4 @@ FetchContent_MakeAvailable(cpr)
 # libcpr in its CMakeLists.txt file disables the BUILD_TESTING globally when
 # CPR_USE_SYSTEM_CURL=OFF. unset BUILD_TESTING here.
 unset(BUILD_TESTING)
+unset(BUILD_SHARED_LIBS)
diff --git a/CMake/resolve_dependency_modules/folly/CMakeLists.txt b/CMake/resolve_dependency_modules/folly/CMakeLists.txt
@@ -50,7 +50,7 @@ set(BUILD_SHARED_LIBS ${VELOX_BUILD_SHARED})
 # Enable INT128 support
 set(FOLLY_HAVE_INT128_T ON)
 FetchContent_MakeAvailable(folly)
-
+unset(BUILD_SHARED_LIBS)
 # Folly::folly is not valid for FC but we want to match FindFolly
 add_library(Folly::folly ALIAS folly)
 add_library(Folly::follybenchmark ALIAS follybenchmark)