[PORT] Fix "close by visitor" #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ruKurz
suggested changes
Feb 14, 2018
There was a problem hiding this comment.
As Rocket.Chat declines this PR, since "there is no Meteor.user() when visitor calls it..." I would not suggest to merge this PR. The issue RocketChat#9558 is solved by RocketChat#9714 which has been merged to 0.61.1 already. Maybe we should check to release0.61.1 instead 0.61.0
|
Agreed, same thoughts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of RocketChat#9698 .
While this is syntactically correct now (and the visitor can close the livechat properly), it is not yet confirmed that the user submitted as the one who closed is set properly.
However, this can be merged imho nevertheless.
@janrudolph please test manually and - if applicable - check the statistics.