Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration SSR #411

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Conversation

MRinaldi9
Copy link
Contributor

This PR integrate a new logic for handling SSR code in Angular, without "forking" logic in service.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ngx-indexed-db ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 1:24pm

@aparzi
Copy link
Collaborator

aparzi commented Nov 16, 2024

Hi @MRinaldi9,
awesome PR. Can you fix CodeFactor issues? Please, also update two package at 19.2.0 and if you want to update the readme to inform users that the library supports SSR

@MRinaldi9
Copy link
Contributor Author

Hi @aparzi,
I can try to fix as many CodeFactor issues as possible, but the requested fixes are related to variables that are not utilized in the server-side implementation of IndexedDB and there is no use for them on the server side, so i don't know if there is a way to inform CodeFactor to avoid the check or use a stratagem for trick CodeFactor.
For the two packages do you intend the library and workspace?
In which section of the Readme do you think is better to add the information about SSR?

@aparzi
Copy link
Collaborator

aparzi commented Nov 16, 2024

@MRinaldi9 for CodeFactor I can inspect, for this point do as you prefer.

  • Yes, package.json in library and workspace. New version 19.1.1

  • I think it's to include on the top description before install chapter. I'm also open also a new ideas.

Many thanks.

@MRinaldi9
Copy link
Contributor Author

As per your request, @aparzi, I have updated the version in package.json, added new sections to the README (including specific integrations), and resolved some of the issues raised by CodeFactor.

@aparzi
Copy link
Collaborator

aparzi commented Nov 17, 2024

Awesome PR 🔥🔥
Can you just update the branch to the latest changes in master? I closed a small issue now.

Thanks

@MRinaldi9
Copy link
Contributor Author

Updated PR with branch master

@aparzi aparzi merged commit 36a4c40 into assuncaocharles:master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants