Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transport separation #117

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Transport separation #117

merged 5 commits into from
Sep 28, 2023

Conversation

sorru94
Copy link
Collaborator

@sorru94 sorru94 commented Sep 19, 2023 •
edited
Loading

Close #115

@sorru94 sorru94 changed the base branch from master to release-0.12 September 19, 2023 09:31
lucaato
lucaato reviewed Sep 21, 2023
View reviewed changes
astarte/device/device.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #117 (941b4a6) into master (a144ba7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   99.84%   99.85%   +0.01%     
==========================================
  Files           9       10       +1     
  Lines         625      674      +49     
==========================================
+ Hits          624      673      +49     
  Misses          1        1
Files Coverage Δ
astarte/device/__init__.py 100.00% <100.00%> (ø)
astarte/device/database.py 100.00% <ø> (ø)
astarte/device/device.py 100.00% <100.00%> (ø)
astarte/device/device_mqtt.py 100.00% <100.00%> (ø)
astarte/device/exceptions.py 100.00% <ø> (ø)
astarte/device/introspection.py 100.00% <ø> (ø)
astarte/device/mapping.py 100.00% <100.00%> (ø)
astarte/device/pairing_handler.py 98.59% <ø> (ø)

@sorru94 sorru94 force-pushed the transport-separation branch 5 times, most recently from 6a0ff16 to 37555b9 Compare September 21, 2023 14:39
@sorru94 sorru94 marked this pull request as ready for review September 21, 2023 14:42
@sorru94 sorru94 force-pushed the transport-separation branch 2 times, most recently from 54e9850 to e635137 Compare September 25, 2023 09:45
@sorru94 sorru94 linked an issue Sep 26, 2023 that may be closed by this pull request
Transport independent functionality should be separated from mqtt functionality #115
Closed
@sorru94
Fixing incorrect capital letters of Python and device
a15e1be 
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94
Split transport specific functionality
a65645e 
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94
Update examples
5197649 
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94
Update end to end tests
aa3a722 
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94
Update readme example
941b4a6 
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94 sorru94 changed the base branch from release-0.12 to master September 27, 2023 09:44
@harlem88 harlem88 merged commit 1d6fd95 into astarte-platform:master Sep 28, 2023
17 checks passed
@sorru94 sorru94 deleted the transport-separation branch November 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgallor rgallor rgallor approved these changes

@joshuachp joshuachp joshuachp approved these changes

@lucaato lucaato lucaato approved these changes

@harlem88 harlem88 harlem88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transport independent functionality should be separated from mqtt functionality
5 participants
@sorru94 @harlem88 @lucaato @joshuachp @rgallor