Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation raising exceptions in place #121

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sorru94
Copy link
Collaborator

@sorru94 sorru94 commented Sep 25, 2023

Closes #120.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #121 (1d0a98b) into master (1d6fd95) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          10       10           
  Lines         674      705   +31     
=======================================
+ Hits          673      704   +31     
  Misses          1        1           
Files Coverage Δ
astarte/device/device.py 100.00% <100.00%> (ø)
astarte/device/interface.py 100.00% <100.00%> (ø)
astarte/device/mapping.py 100.00% <100.00%> (ø)

@sorru94 sorru94 force-pushed the in-place-exceptions branch 3 times, most recently from eb4c05b to 0201dfc Compare September 28, 2023 10:01
@sorru94 sorru94 force-pushed the in-place-exceptions branch 2 times, most recently from 172ff8c to 9c76dee Compare September 28, 2023 14:14
astarte/device/interface.py Show resolved Hide resolved
astarte/device/interface.py Show resolved Hide resolved
astarte/device/mapping.py Outdated Show resolved Hide resolved
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94 sorru94 marked this pull request as ready for review September 28, 2023 16:06
@harlem88 harlem88 merged commit 15bbe45 into astarte-platform:master Sep 29, 2023
17 checks passed
@sorru94 sorru94 deleted the in-place-exceptions branch November 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During interface/mapping validation raise exceptions should be raised in place
5 participants