Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove interfaces while connected #122

Merged

Conversation

sorru94
Copy link
Collaborator

@sorru94 sorru94 commented Sep 25, 2023

Close #119

@sorru94 sorru94 force-pushed the add-rmv-interfaces-while-connected branch from af88ce4 to d05540c Compare September 25, 2023 14:03
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #122 (b71be12) into master (15bbe45) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   99.85%   99.86%           
=======================================
  Files          10       10           
  Lines         705      743   +38     
=======================================
+ Hits          704      742   +38     
  Misses          1        1           
Files Coverage Δ
astarte/device/__init__.py 100.00% <ø> (ø)
astarte/device/database.py 100.00% <100.00%> (ø)
astarte/device/device.py 100.00% <ø> (ø)
astarte/device/device_mqtt.py 100.00% <100.00%> (ø)
astarte/device/exceptions.py 100.00% <100.00%> (ø)

@sorru94 sorru94 force-pushed the add-rmv-interfaces-while-connected branch 11 times, most recently from 2470c0e to 0d865b4 Compare September 29, 2023 08:42
astarte/device/device_mqtt.py Outdated Show resolved Hide resolved
astarte/device/device_mqtt.py Outdated Show resolved Hide resolved
astarte/device/device_mqtt.py Outdated Show resolved Hide resolved
@sorru94 sorru94 requested a review from lucaato October 2, 2023 10:43
@sorru94 sorru94 marked this pull request as ready for review October 2, 2023 10:43
@sorru94 sorru94 requested a review from harlem88 October 2, 2023 10:43
@sorru94 sorru94 force-pushed the add-rmv-interfaces-while-connected branch from e2628f2 to 1a093fe Compare October 2, 2023 10:55
astarte/device/device_mqtt.py Outdated Show resolved Hide resolved
@sorru94 sorru94 force-pushed the add-rmv-interfaces-while-connected branch from 18ebe7e to 88b18d7 Compare October 4, 2023 09:10
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94 sorru94 force-pushed the add-rmv-interfaces-while-connected branch from 88b18d7 to 27574ff Compare October 4, 2023 09:41
@sorru94 sorru94 requested a review from harlem88 October 4, 2023 09:45
Copy link
Collaborator

@harlem88 harlem88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry to the cahngelog about dynamic introspection.

Signed-off-by: Simone Orru <simone.orru@secomind.com>
@sorru94 sorru94 requested a review from harlem88 October 4, 2023 13:22
@harlem88 harlem88 merged commit c356ebb into astarte-platform:master Oct 5, 2023
17 checks passed
@sorru94 sorru94 deleted the add-rmv-interfaces-while-connected branch October 5, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding/removing interfaces after the call to connect does not work correctly
4 participants