-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rust code generation #3
Conversation
61eb355
to
b60e924
Compare
6ce23ea
to
c447304
Compare
b52a8ed
to
6c2f269
Compare
Signed-off-by: Antonio Gisondi <antonio.gisondi@secomind.com>
ebafc61
to
36ca721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
d4cd3c9
to
789f822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming some of the checkers could make the CI clearer. The three checkers below are very similar.
check-code-generation.yaml
rust-check-build.yaml
rust-code-check.yaml
check-code-generation.yaml
will also eventually contain the check for Python right? If so then the generic name looks good.
I would rename rust-check-build.yaml
to something more explicative. The check is on the build tools, not the building process. How about something like rust-check-builder.yaml
, rust-check-tools.yaml
.
For rust-code-check.yaml
the name could be similar to check-code-generation.yaml
since the purpose is the same but only for Rust files. How about something like rust-check-code-generation.yaml
?
My suggestion is also for the workflow name
contained in the .yaml
files. Those names could be similar to the file name in order to make the file easy to find knowing only the name and vice-versa.
Signed-off-by: Antonio Gisondi <antonio.gisondi@secomind.com>
b48337d
to
0a212d5
Compare
Signed-off-by: Antonio Gisondi <antonio.gisondi@secomind.com>
The rust code generated by proto files wad added under version control, on each pull_request a CI action will check if there is a difference between the code generated by CI and the rust code committed in the Pull Request.