Avoid sending the node id in the Attach rpc #58
Conversation
| @@ -23,6 +23,11 @@ syntax = "proto3"; | |||
|
|
|||
| package astarteplatform.msghub; | |||
|
|
|||
| /* This message defines the introspection a node should send when attaching to the Astarte message hub. */ | |||
| message Introspection { | |||
There was a problem hiding this comment.
The Introspection and InterfacesJson messages might be confusing as the difference between them is unclear.
If the content is the same, why not use InterfacesJson in the Attach method?
There was a problem hiding this comment.
Yep, I had the same thought, still I decided to differentiate the 2 messages since Introspection represents the whole set of interfaces transmitted during the attach procedure, whereas InterfacesJson may represent a subset of them or new interfaces to be added to the Node interfaces. Nevertheless, since both the 2 messages represent a set of interfaces, it seems reasonable to use only one of them (the most generic one, thus InterfacesJson).
There was a problem hiding this comment.
@harlem88 @joshuachp what's your opinion?
There was a problem hiding this comment.
I think that having two structures would be better in this case, so in the future we can add additional fields to the rcp Attach message (now called Introspection) and still be backwards compatible.
Perhaps the name Introspection is confusing in this case, I would keep the Node message or a rename it to something related to the Attach call, and with a field called introspection inside.
If we keep the Node message, it will be a smaller change since we only have to remove the UUID field.
There was a problem hiding this comment.
Yes, probably maintaining the Node parameter in the Attach rpc (with only the introspection data) is a good option, also for backward compatibility
rgallor
force-pushed
the
refactor/node-id
branch
from
d4bed0d to
2a0c3b9
Compare
rgallor
force-pushed
the
refactor/node-id
branch
from
48d0ac6 to
894d42f
Compare
Avoid sending the node id in the attach rpc since it is already inserted in grpc metadata of every rpc the node send. Also, remove generated .py files when executing `make install`. Signed-off-by: Riccardo Gallo <riccardo.gallo@secomind.com>
rgallor
force-pushed
the
refactor/node-id
branch
from
894d42f to
6821a5c
Compare
Avoid sending the node id in the attach rpc since it is already inserted in grpc metadata of every rpc the node send.