AstarteE2E: update to Elixir 1.14.x #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annopaolo
approved these changes
Nov 7, 2023
Annopaolo
reviewed
Nov 7, 2023
There was a problem hiding this comment.
LGTM, thank you! Also, the Elixir/Erlang version should be bumped also in the e2e CI workflow (see
astarte/.github/workflows/astarte-end-to-end-test-workflow.yaml
Lines 23 to 24 in 01c8510
Annopaolo
requested changes
Nov 7, 2023
Annopaolo
requested changes
Nov 7, 2023
osmanhadzic
force-pushed
the
astarte-e2e_update_elixir
branch
from
8d310d1
to
a17db28
Compare
Annopaolo
requested changes
Nov 7, 2023
osmanhadzic
force-pushed
the
astarte-e2e_update_elixir
branch
from
a17db28
to
7614475
Compare
Annopaolo
approved these changes
Nov 9, 2023
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
astarte-e2e_update_elixir
branch
from
7614475
to
873d185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Elixir verison to 1.14
Update dependencies websocket_client, phoenix_gen_socket_client
Closes: #858