Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byebug #18

Merged
merged 6 commits into from
Nov 11, 2014
Merged

Add byebug #18

merged 6 commits into from
Nov 11, 2014

Conversation

astashov
Copy link
Owner

No description provided.

@os97673
Copy link
Collaborator

os97673 commented Oct 18, 2014

@astashov Wow!!! Great progress! Let me know when the new version of the gem will be published and I will add integration for it.

@astashov
Copy link
Owner Author

Sure. It's about to be done, I need deivid-rodriguez/byebug#89 to be accepted, and then I could merge this one. I tested it with vim-ruby-debugger - works fine.

astashov added a commit that referenced this pull request Nov 11, 2014
@astashov astashov merged commit 996d003 into master Nov 11, 2014
@astashov astashov deleted the add-byebug branch November 11, 2014 18:06
@os97673
Copy link
Collaborator

os97673 commented Nov 11, 2014

@astashov please let me know when a new version will be published (and its version number)

@astashov
Copy link
Owner Author

Sure, will do. Blocked by byebug release for now.

@deivid-rodriguez
Copy link

Hi guys, I'll be releasing a new version soon. Will keep you posted.

@deivid-rodriguez
Copy link

Guys, I'm having a regression in byebug's master right now (54). It's related to the lack of proper threading support which is what I'll be working on in the next couple months. So I'd rather wait till it is fixed before releasing.

Is there any way you guys can try this without me having to release?

@astashov
Copy link
Owner Author

astashov commented Dec 5, 2014

Umm, how? I cannot add github source to gemspec, right?

@deivid-rodriguez
Copy link

You can add it to the Gemfile.

@astashov
Copy link
Owner Author

astashov commented Dec 5, 2014

But it won't work if someone would want to add 'debugger-xml' to their project, to their Gemfile, right? Or it will?

@deivid-rodriguez
Copy link

Never tried that, but I'm pretty sure if they add both debugger-xml and byebug to their Gemfile pointing to both master branches it should work.

By the way, I've made some changes that affect debugger-xml support. Specifically, I've removed Context.stack_size and changed it to an instance method.

@astashov
Copy link
Owner Author

astashov commented Dec 5, 2014

Yeah, I guess I can put that to README for now...

@deivid-rodriguez
Copy link

Thanks @astashov , I'll do my best to release as soon as possible.

@astashov
Copy link
Owner Author

astashov commented Dec 5, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants