Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan_pjsip: Test Session Timer #18

Merged

Conversation

btriller
Copy link
Contributor

Test if chan_pjsip replies w/ 422 (Session Interval Too Small) response to an INVITE request w/ Session-Expires lower than timers_min_se setting.

@btriller btriller force-pushed the pjsip-session-timer-minse branch from 355ad88 to 08be9f4 Compare August 28, 2023 06:22
@asterisk-org-access-app asterisk-org-access-app bot requested a review from a team August 28, 2023 06:22
@asterisk-org-access-app
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required".

@btriller
Copy link
Contributor Author

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

@btriller
Copy link
Contributor Author

See asterisk/asterisk#279

Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to squash and remove the merge commit.

Test if chan_pjsip replies w/ 422 (Session Interval Too Small) response
to an INVITE request w/ Session-Expires lower than timers_min_se
setting.
@btriller btriller force-pushed the pjsip-session-timer-minse branch from 53388dc to 5e42caa Compare September 22, 2023 14:24
@gtjoseph gtjoseph self-requested a review September 22, 2023 14:26
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Sep 22, 2023
@asterisk-org-access-app asterisk-org-access-app bot merged commit 8c46fba into asterisk:master Sep 22, 2023
20 checks passed
@github-actions
Copy link

Successfully merged to branch master and cherry-picked to ["18","20","21"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants