Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Commit

Permalink
Address code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaReiser committed Jul 24, 2023
1 parent 4574637 commit e456660
Show file tree
Hide file tree
Showing 12 changed files with 381 additions and 490 deletions.
2 changes: 1 addition & 1 deletion ast/src/generic.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#![allow(clippy::derive_partial_eq_without_eq)]
use crate::text_size::TextRange;
pub use crate::{builtin::*, text_size::TextSize, ConversionFlag, Node};
pub(crate) use crate::{builtin::*, ConversionFlag, Node};
use std::fmt::Debug;

// This file was originally generated from asdl by a python script, but we now edit it manually
Expand Down
2 changes: 0 additions & 2 deletions ast/src/ranged.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

use crate::text_size::{TextRange, TextSize};

pub use crate::builtin::*;

pub trait Ranged {
fn range(&self) -> TextRange;

Expand Down
4 changes: 2 additions & 2 deletions parser/src/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ use rustc_hash::FxHashSet;
use rustpython_ast::Ranged;

pub(crate) struct ArgumentList {
pub args: Vec<ast::Expr>,
pub keywords: Vec<ast::Keyword>,
pub(crate) args: Vec<ast::Expr>,
pub(crate) keywords: Vec<ast::Keyword>,
}

// Perform validation of function/lambda arguments in a function definition.
Expand Down
Loading

0 comments on commit e456660

Please sign in to comment.