This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Optimize validate_arguments
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/dicts
branch
from
13fdbc8 to
d68b16a
Compare
|
This could in theory be merged upstream, what's the workflow for that these days? |
It's complicated :D You can create a new branch by forking from upstream rather our version. Make your changes and submit your PR to RustPython. After merge: Merge the changes downstream by using |
MichaReiser
approved these changes
Jun 19, 2023
|
Nice! I didn't expect you to split this out into its own PR but thakn you |
charliermarsh
force-pushed
the
charlie/dicts
branch
from
d68b16a to
2cc83ff
Compare
charliermarsh
force-pushed
the
charlie/dicts
branch
from
2cc83ff to
93c49d3
Compare
zanieb
pushed a commit
that referenced
this pull request
Jul 10, 2023
zanieb
pushed a commit
that referenced
this pull request
Jul 17, 2023
zanieb
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor optimizations to
validate_arguments, to avoid duplicate lookups, pre-allocate the vector, etc.