Use --output-format instead of --format
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 7, 2023
|
I want to add some tests to make sure this is backwards compatible — let's not merge yet |
zanieb
force-pushed
the
zanie/output-format
branch
from
168aded to
f6eee83
Compare
zanieb
added a commit
that referenced
this pull request
Oct 11, 2023
Adds test coverage for the oldest supported Ruff version by adding the Ruff version to the CI test matrix. The Ruff versions in the matrix are generated by parsing the lower pin from our `pyproject.toml` and the latest release from GitHub. I opted for this approach because it's nice to see the version being tested in the CI job names and it does not require manual updates. The `just check` job was split out from tests because it requires `ruff format` which is not available in old releases. The tests did not pass on the old release of Ruff due missing `format` support and the new documentation domain. I've added toggles in the test to address those cases based on the Ruff version being tested. Motivated by a desire for test coverage in #266
zanieb
force-pushed
the
zanie/output-format
branch
from
f6eee83 to
2617951
Compare
|
Tests added in #270 let's see... |
charliermarsh
approved these changes
Oct 12, 2023
dhruvmanila
reviewed
Oct 12, 2023
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
This was referenced Oct 16, 2023
Closed
azurelotus0926
added a commit
to azurelotus0926/ruff-lsp
that referenced
this pull request
Jun 27, 2024
Adds test coverage for the oldest supported Ruff version by adding the Ruff version to the CI test matrix. The Ruff versions in the matrix are generated by parsing the lower pin from our `pyproject.toml` and the latest release from GitHub. I opted for this approach because it's nice to see the version being tested in the CI job names and it does not require manual updates. The `just check` job was split out from tests because it requires `ruff format` which is not available in old releases. The tests did not pass on the old release of Ruff due missing `format` support and the new documentation domain. I've added toggles in the test to address those cases based on the Ruff version being tested. Motivated by a desire for test coverage in astral-sh/ruff-lsp#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--formatis deprecated; includes backwards compatibility so we do not need to bump the linter version