Enable fix/formatting commands for Python and Jupyter Notebook files only #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
approved these changes
Jun 5, 2024
MichaReiser
requested changes
Jun 5, 2024
Comment on lines
+378
to
+386
| "when": "resourceExtname == .py || resourceExtname == .pyi || resourceExtname == .ipynb" | ||
| }, | ||
| { | ||
| "command": "ruff.executeFormat", | ||
| "when": "resourceExtname == .py || resourceExtname == .pyi || resourceExtname == .ipynb" | ||
| }, | ||
| { | ||
| "command": "ruff.executeOrganizeImports", | ||
| "when": "resourceExtname == .py || resourceExtname == .pyi || resourceExtname == .ipynb" |
There was a problem hiding this comment.
Hmm, I don't think we can do that. You can configure ruff to lint files with arbitrary extensions using extend-include. These files would no longer be linted. It also means that auto fix would no longer run on any new/untitled files because they don't have an extension yet (they only have an associated language that we should probably use in the LSP).
There was a problem hiding this comment.
You're right, this wouldn't work with arbitrary file extensions.
I might try using @dhruvmanila's suggestion and just handle the snapshot not available error more gracefully in ruff server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ruff#11744.
The extension would allow commands like
ruff.applyAutofixto run on any file, even non-Python files. This PR adds a command palette filter so that these commands only appear in the palette when working with Python or Jupyter Notebook files.Test Plan
Ensure that commands like
Ruff: Fix all auto-fixable problemsstill appear in the command palette (Ctrl/Cmd + Shift + P) for files with the following extensions:*.py*.pyi*.ipynbThen, ensure that these commands do not appear for other kinds of files (for example:
*.tomlor*.json).Ruff: Restart servershould still be available.