Avoid awaiting VS Code popup notifications

[dhruvmanila]

Summary

This PR fixes a bug to avoid awaiting the VS Code popup notifications.

How to reproduce this?

For posterity, this is how to reproduce this bug:

1. Keep the extension setting to only contain:

{
	"ruff.nativeServer": true
}

2. Add the following additional setting which is incompatible with the native server:

{
	"ruff.nativeServer": true,
	"ruff.format.args": ["--line-length=10"]
}

3. Saving the new settings will trigger a restart and a notification will popup which warns you about this incompatible setting (Do NOT dismiss the notification window)
4. Remove the ruff.format.args and save the settings which should then trigger a restart again

But, the restart triggered by (3) never completed because the notification was awaited and the user never dismissed it. This is where the extension hangs.

Solution

I've updated all vscode.window.show(Error|Warning)Message calls to not be awaited and instead use the callback mechanism if there's a need to respond to user's selection.

Test Plan

Follow the same steps as above and make sure that the restart happens.

Screen.Recording.2024-07-24.at.17.14.56.mov

[MichaReiser]

Nit: Maybe add an error handler that logs a message if showing the message box fails for whatever reason

Suggested change

	vscode.window.showWarningMessage(message, "Show Logs").then((selection) => {
	if (selection) {
	outputChannel.show();
	}
	});
	vscode.window.showWarningMessage(message, "Show Logs").then((selection) => {
	if (selection) {
	outputChannel.show();
	}
	}).catch(ex => logError("Failed to show warning message: {ex}"));

[dhruvmanila]

We could do it but there are multiple instances of these calls 🤷‍♂️