Use try ... finally to always reset debounce state
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
changed the title
try .. finally to always reset debounce statetry ... finally to always reset debounce state
dhruvmanila
force-pushed
the
dhruv/finally
branch
from
c07319f
to
1246edc
Compare
MichaReiser
reviewed
Jul 24, 2024
| restartQueued = false; | ||
| await runServer(); | ||
| if (restartQueued) { | ||
| restartQueued = false; |
There was a problem hiding this comment.
I think we might still need to set restartInProgress to false before calling into runServer or the function will exit early. The alternative is to split the function even more: One with the restartInProgress check (e.g. debouncedRestartServer and one without.
There was a problem hiding this comment.
I'm confused a bit. Can you expand in which case it could be false? I'm unable to follow here.
There was a problem hiding this comment.
The queued restart block has been moved into the finally block where it should've been which resolves the race condition I was hitting (shared on Discord).
dhruvmanila
force-pushed
the
dhruv/finally
branch
from
1246edc
to
382286f
Compare
MichaReiser
approved these changes
Jul 24, 2024
dhruvmanila
added a commit
that referenced
this pull request
Jul 24, 2024
## Summary Follow-up to #558 This PR separates the server start and stop logic. This is required because the extension could skip starting the server in the following cases: 1. No Python interpreter is selected 2. Python extension is unable to resolve the environment for the given Python interpreter 3. Python version is incompatible So, if the extension was already running and the settings were updated to hit any one of the above cases, the server would still be running (not ideal). ## Test Plan Here, the diagnostics should disappear because the server stopped first before checking for the interpreter. For (1), I'd need to uninstall all Python versions for me to reproduce this so I'm skipping this scenario assuming that (2) and (3) is sufficient. For (2), https://github.com/user-attachments/assets/124ab434-c082-4e67-a606-24040d8f04a8 For (3), https://github.com/user-attachments/assets/2300ee88-01be-45be-9c03-ae2ff4aeda78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a refactor to use
try .. finallyin the logic which starts the server to always reset the debounce state variable (restartInProgress). This is to ensure that it's always reset even in case of a failure.Test Plan
Refer to the test plan in #559.