Add deprecation warning for ruff-lsp specific settings
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/deprecate
branch
from
8b8f534 to
1379e8b
Compare
MichaReiser
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the deprecation message to
ruff-lspspecific settings and update the README section with a warning message.There doesn't seem to be any way to show this to the user as the settings are now not visible in the settings UI although they're visible in the JSON viewer:
But, it's not visible in the hover window of the settings:
Deprecation warning
Additionally, the extension will provide a deprecation warning when Ruff version if < 0.3.5. For >= 0.3.5,
ruff-lspwill provide the warning (astral-sh/ruff-lsp#520).Preview of this warning: