Fix commented-out coalesce keyword (#7876)

See: #7874 (comment).
astral-sh · Oct 11, 2023 · 04aed23 · 04aed23
1 parent e166da5
commit 04aed23
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/crates/ruff_linter/src/rules/flake8_boolean_trap/helpers.rs b/crates/ruff_linter/src/rules/flake8_boolean_trap/helpers.rs
@@ -12,7 +12,7 @@ pub(super) fn is_allowed_func_call(name: &str) -> bool {
             | "assertNotEquals"
             | "bool"
             | "bytes"
-            // | "coalesce"
+            | "coalesce"
             | "count"
             | "failIfEqual"
             | "failUnlessEqual"

diff --git a/...boolean_trap/snapshots/ruff_linter__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap b/...boolean_trap/snapshots/ruff_linter__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap
@@ -38,12 +38,4 @@ FBT.py:69:38: FBT003 Boolean positional value in function call
 71 | bar.is_not(False)
    |
 
-FBT.py:73:31: FBT003 Boolean positional value in function call
-   |
-71 | bar.is_not(False)
-72 | next(iter([]), False)
-73 | sa.func.coalesce(tbl.c.valid, False)
-   |                               ^^^^^ FBT003
-   |
-