Don't treat straight imports of __future__ as '__future__' imports

astral-sh · Jun 15, 2023 · 6c92add · 6c92add
1 parent 5ea3e42
commit 6c92add
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 26 deletions.
diff --git a/crates/ruff/src/checkers/ast/mod.rs b/crates/ruff/src/checkers/ast/mod.rs
@@ -805,24 +805,7 @@ where
                 }
 
                 for alias in names {
-                    if &alias.name == "__future__" {
-                        let name = alias.asname.as_ref().unwrap_or(&alias.name);
-                        self.add_binding(
-                            name,
-                            alias.identifier(self.locator),
-                            BindingKind::FutureImportation,
-                            BindingFlags::empty(),
-                        );
-
-                        if self.enabled(Rule::LateFutureImport) {
-                            if self.semantic.seen_futures_boundary() {
-                                self.diagnostics.push(Diagnostic::new(
-                                    pyflakes::rules::LateFutureImport,
-                                    stmt.range(),
-                                ));
-                            }
-                        }
-                    } else if alias.name.contains('.') && alias.asname.is_none() {
+                    if alias.name.contains('.') && alias.asname.is_none() {
                         // Given `import foo.bar`, `name` would be "foo", and `qualified_name` would be
                         // "foo.bar".
                         let name = alias.name.split('.').next().unwrap();

diff --git a/crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F404_F404.py.snap b/crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F404_F404.py.snap
@@ -11,12 +11,4 @@ F404.py:6:1: F404 `from __future__` imports must occur at the beginning of the f
 8 | import __future__
   |
 
-F404.py:8:1: F404 `from __future__` imports must occur at the beginning of the file
-  |
-6 | from __future__ import print_function
-7 | 
-8 | import __future__
-  | ^^^^^^^^^^^^^^^^^ F404
-  |
-