Rename to unnecessary-from-float

astral-sh · Mar 30, 2024 · ea80455 · ea80455
1 parent 6dc7e92
commit ea80455
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/crates/ruff_linter/src/checkers/ast/analyze/expression.rs b/crates/ruff_linter/src/checkers/ast/analyze/expression.rs
@@ -929,8 +929,8 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
             if checker.enabled(Rule::VerboseDecimalConstructor) {
                 refurb::rules::verbose_decimal_constructor(checker, call);
             }
-            if checker.enabled(Rule::VerboseDecimalFractionConstruction) {
-                refurb::rules::verbose_decimal_fraction_construction(checker, call);
+            if checker.enabled(Rule::UnnecessaryFromFloat) {
+                refurb::rules::unnecessary_from_float(checker, call);
             }
             if checker.enabled(Rule::QuadraticListSummation) {
                 ruff::rules::quadratic_list_summation(checker, call);

diff --git a/crates/ruff_linter/src/codes.rs b/crates/ruff_linter/src/codes.rs
@@ -1051,7 +1051,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Refurb, "157") => (RuleGroup::Preview, rules::refurb::rules::VerboseDecimalConstructor),
         (Refurb, "161") => (RuleGroup::Preview, rules::refurb::rules::BitCount),
         (Refurb, "163") => (RuleGroup::Preview, rules::refurb::rules::RedundantLogBase),
-        (Refurb, "164") => (RuleGroup::Preview, rules::refurb::rules::VerboseDecimalFractionConstruction),
+        (Refurb, "164") => (RuleGroup::Preview, rules::refurb::rules::UnnecessaryFromFloat),
         (Refurb, "167") => (RuleGroup::Preview, rules::refurb::rules::RegexFlagAlias),
         (Refurb, "168") => (RuleGroup::Preview, rules::refurb::rules::IsinstanceTypeNone),
         (Refurb, "169") => (RuleGroup::Preview, rules::refurb::rules::TypeNoneComparison),

diff --git a/crates/ruff_linter/src/rules/refurb/mod.rs b/crates/ruff_linter/src/rules/refurb/mod.rs
@@ -27,7 +27,7 @@ mod tests {
     #[test_case(Rule::UnnecessaryEnumerate, Path::new("FURB148.py"))]
     #[test_case(Rule::MathConstant, Path::new("FURB152.py"))]
     #[test_case(Rule::VerboseDecimalConstructor, Path::new("FURB157.py"))]
-    #[test_case(Rule::VerboseDecimalFractionConstruction, Path::new("FURB164.py"))]
+    #[test_case(Rule::UnnecessaryFromFloat, Path::new("FURB164.py"))]
     #[test_case(Rule::PrintEmptyString, Path::new("FURB105.py"))]
     #[test_case(Rule::ImplicitCwd, Path::new("FURB177.py"))]
     #[test_case(Rule::SingleItemMembershipTest, Path::new("FURB171.py"))]

diff --git a/crates/ruff_linter/src/rules/refurb/rules/mod.rs b/crates/ruff_linter/src/rules/refurb/rules/mod.rs
@@ -21,8 +21,8 @@ pub(crate) use single_item_membership_test::*;
 pub(crate) use slice_copy::*;
 pub(crate) use type_none_comparison::*;
 pub(crate) use unnecessary_enumerate::*;
+pub(crate) use unnecessary_from_float::*;
 pub(crate) use verbose_decimal_constructor::*;
-pub(crate) use verbose_decimal_fraction_construction::*;
 
 mod bit_count;
 mod check_and_remove_from_set;
@@ -47,5 +47,5 @@ mod single_item_membership_test;
 mod slice_copy;
 mod type_none_comparison;
 mod unnecessary_enumerate;
+mod unnecessary_from_float;
 mod verbose_decimal_constructor;
-mod verbose_decimal_fraction_construction;
diff --git a/.../verbose_decimal_fraction_construction.rs → ...es/refurb/rules/unnecessary_from_float.rs b/.../verbose_decimal_fraction_construction.rs → ...es/refurb/rules/unnecessary_from_float.rs
@@ -44,12 +44,12 @@ use crate::{checkers::ast::Checker, importer::ImportRequest};
 /// - [Python documentation: `decimal`](https://docs.python.org/3/library/decimal.html)
 /// - [Python documentation: `fractions`](https://docs.python.org/3/library/fractions.html)
 #[violation]
-pub struct VerboseDecimalFractionConstruction {
+pub struct UnnecessaryFromFloat {
     method_name: String,
     constructor: String,
 }
 
-impl Violation for VerboseDecimalFractionConstruction {
+impl Violation for UnnecessaryFromFloat {
     const FIX_AVAILABILITY: FixAvailability = FixAvailability::Sometimes;
 
     #[derive_message_formats]
@@ -66,7 +66,7 @@ impl Violation for VerboseDecimalFractionConstruction {
 }
 
 /// FURB164
-pub(crate) fn verbose_decimal_fraction_construction(checker: &mut Checker, call: &ExprCall) {
+pub(crate) fn unnecessary_from_float(checker: &mut Checker, call: &ExprCall) {
     let Some(qualified_name) = checker.semantic().resolve_qualified_name(&call.func) else {
         return;
     };
@@ -92,7 +92,7 @@ pub(crate) fn verbose_decimal_fraction_construction(checker: &mut Checker, call:
     };
 
     let mut diagnostic = Diagnostic::new(
-        VerboseDecimalFractionConstruction {
+        UnnecessaryFromFloat {
             method_name: (*method_name).to_string(),
             constructor: (*constructor).to_string(),
         },