Implement visitation of type alias statements in the checker

astral-sh · Jul 26, 2023 · fcd5e14 · fcd5e14
1 parent e923e3f
commit fcd5e14
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/crates/ruff/src/checkers/ast/mod.rs b/crates/ruff/src/checkers/ast/mod.rs
@@ -586,6 +586,20 @@ where
 
                 self.visit_body(body);
             }
+            Stmt::TypeAlias(ast::StmtTypeAlias {
+                range: _range,
+                name,
+                type_params,
+                value,
+            }) => {
+                self.semantic.push_scope(ScopeKind::Type);
+                for type_param in type_params {
+                    self.visit_type_param(type_param);
+                }
+                self.visit_expr(value);
+                self.semantic.pop_scope();
+                self.visit_expr(name);
+            }
             Stmt::Try(ast::StmtTry {
                 body,
                 handlers,

diff --git a/crates/ruff_python_ast/src/visitor.rs b/crates/ruff_python_ast/src/visitor.rs
@@ -186,10 +186,10 @@ pub fn walk_stmt<'a, V: Visitor<'a> + ?Sized>(visitor: &mut V, stmt: &'a Stmt) {
             type_params,
             value,
         }) => {
+            visitor.visit_expr(value);
             for type_param in type_params {
                 visitor.visit_type_param(type_param);
             }
-            visitor.visit_expr(value);
             visitor.visit_expr(name);
         }
         Stmt::Assign(ast::StmtAssign { targets, value, .. }) => {