Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for string type hint in typing.Annotated #10279

Closed
minmax opened this issue Mar 7, 2024 · 1 comment · Fixed by #10285
Closed

Add support for string type hint in typing.Annotated #10279

minmax opened this issue Mar 7, 2024 · 1 comment · Fixed by #10285
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@minmax
Copy link

minmax commented Mar 7, 2024

String type hints used in Annotated should be imported in TYPE_CHECKING section, but ruff remove imports for now.
I think ruff should treat the first argument of Annotated similar to the current behavior for ClassVar.

from types import FunctionType  # `types.FunctionType` imported but unused F401
from typing import Annotated

Func = Annotated["FunctionType", int]

ruff 0.3.0
@charliermarsh charliermarsh self-assigned this Mar 7, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Mar 7, 2024
@charliermarsh
Copy link
Member

This looks like a bug, probably just an oversight...

@charliermarsh charliermarsh mentioned this issue Mar 8, 2024
Merged
charliermarsh added a commit that referenced this issue Mar 8, 2024
@charliermarsh
Treat typing.Annotated subscripts as type definitions (#10285)
57be3fc 
## Summary

I think this code has existed since the start of `typing.Annotated`
support (#333), and was then
overlooked over a series of refactors.

Closes #10279.
nkxxll pushed a commit to nkxxll/ruff that referenced this issue Mar 10, 2024
@charliermarsh @nkxxll
Treat typing.Annotated subscripts as type definitions (astral-sh#10285
8f6cb9d 
)

## Summary

I think this code has existed since the start of `typing.Annotated`
support (astral-sh#333), and was then
overlooked over a series of refactors.

Closes astral-sh#10279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat typing.Annotated subscripts as type definitions astral-sh/ruff
2 participants
@minmax @charliermarsh