-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ALL" should ignore deprecated rules #10342
Comments
I don't think we can have deprecation be a breaking change i.e. a rule turns off when it was previously on. It's an interesting idea though. I think it would make a lot of sense to deselect these in preview mode (if we don't already? I think we do?). |
It is turned off in preview mode. From https://docs.astral.sh/ruff/linter/#rule-selection:
|
Hm that's fair... I do prefer this to #9778 so okay let's do it :) |
I'm going to assign myself but if anyone is interested in grabbing this feel free and I'll just be the reviewer. |
@zanieb Hi! |
@WindowGenerator go for it! |
Wow, thanks. This is just my second issue here and I have to say, that you are as fast as ruff... |
Could it also make sense, to add a configuration option in the pyproject.toml that automatically ignores all deprecated rules? |
@marc-benz That was discussed a bit in #9778 I guess? I'm pretty hesitant to add that though. They'd also be ignored by switching |
It would be nice, if
--select=ALL
would ignore already deprecated rules.I think, situations, where you select "ALL", but do not want to ignore already deprecated rules are rare (but this is just a gut feeling).
see also #9778
The text was updated successfully, but these errors were encountered: