E303: missing detection

[spaceone]

E303 not detected for:

#



import foo


def bar() -> list[str]:
    pass

flake8 detects: :5:1: E303 too many blank lines (3)

[boolean-light]

I have tried all errors from E301 to E306 with --preview option, but none of them worked.

[dhruvmanila]

Thanks for the report.

From the implementation side, I guess this must be a bug in the order in which the check is performed:

ruff/crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs

Lines 699 to 701 in dacec73

	if state.is_not_first_logical_line {
	self.check_line(&logical_line, &state, prev_indent_length, diagnostics);
	}

and the state is being updated:

ruff/crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs

Lines 735 to 736 in dacec73

	if !logical_line.is_comment_only {
	state.is_not_first_logical_line = true;

/cc @hoel-bagard

[hoel-bagard]

I'll have a look at it, thanks for reporting the bug.