Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jupyter Notebooks to Ruff's default inclusion #12456

Closed
dhruvmanila opened this issue Jul 22, 2024 · 1 comment
Closed

Add Jupyter Notebooks to Ruff's default inclusion #12456

dhruvmanila opened this issue Jul 22, 2024 · 1 comment
Assignees
@dhruvmanila
Labels
breaking Breaking API change configuration Related to settings and configuration
Milestone
v0.6

Comments

@dhruvmanila
Copy link
Member

I think it's time we promote Jupyter Notebooks to be included by default in Ruff i.e., promote notebook files to stable.

This requires a minor version bump.

Also, the new native server doesn't run on Jupyter Notebooks unless it's explicitly included using a configuration file.

Reference:
@dhruvmanila dhruvmanila added breaking Breaking API change configuration Related to settings and configuration labels Jul 22, 2024
@dhruvmanila dhruvmanila added this to the v0.6 milestone Jul 22, 2024
@dhruvmanila dhruvmanila mentioned this issue Jul 22, 2024
Closed
@MichaReiser
Copy link
Member

Let's make this change in preview so that we can release it with 0.6

@MichaReiser MichaReiser self-assigned this Aug 2, 2024
@MichaReiser MichaReiser mentioned this issue Aug 2, 2024
Merged
@MichaReiser MichaReiser removed their assignment Aug 12, 2024
@MichaReiser MichaReiser modified the milestones: v0.6, v0.7 Aug 12, 2024
@dhruvmanila dhruvmanila mentioned this issue Aug 14, 2024
Merged
3 tasks
@dhruvmanila dhruvmanila modified the milestones: v0.7, v0.6 Aug 14, 2024
@dhruvmanila dhruvmanila self-assigned this Aug 14, 2024
AlexWaygood added a commit that referenced this issue Aug 14, 2024
@dhruvmanila @AlexWaygood
Stabilize support for Jupyter Notebooks (#12878)
524a86a 
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Closes: #12456
Closes: astral-sh/ruff-vscode#546
MichaReiser pushed a commit that referenced this issue Aug 14, 2024
@dhruvmanila @AlexWaygood @MichaReiser
Stabilize support for Jupyter Notebooks (#12878)
8da1c12 
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Closes: #12456
Closes: astral-sh/ruff-vscode#546
MichaReiser pushed a commit that referenced this issue Aug 14, 2024
@dhruvmanila @AlexWaygood @MichaReiser
Stabilize support for Jupyter Notebooks (#12878)
73160dc 
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Closes: #12456
Closes: astral-sh/ruff-vscode#546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
breaking Breaking API change configuration Related to settings and configuration
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
3 participants
@MichaReiser @AlexWaygood @dhruvmanila