Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider ignore-names in more rules #5050

Closed
Thomasdezeeuw opened this issue Jun 13, 2023 · 0 comments · Fixed by #5079
Closed

Consider ignore-names in more rules #5050

Thomasdezeeuw opened this issue Jun 13, 2023 · 0 comments · Fixed by #5079
Assignees
@Thomasdezeeuw
Labels
bug Something isn't working

Comments

@Thomasdezeeuw
Copy link
Contributor

Currently Ruff doesn't consider the ignore-names flag in all rules, see #5024 (comment).
@Thomasdezeeuw Thomasdezeeuw self-assigned this Jun 13, 2023
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jun 13, 2023
Merged
@charliermarsh charliermarsh added the bug Something isn't working label Jun 13, 2023
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jun 14, 2023
Merged
Thomasdezeeuw pushed a commit that referenced this issue Jun 14, 2023
Consider ignore-names in all pep8 naming rules (#5079)
e7316c1 
## Summary

This changes all remaining pep8 naming rules to consider the
`ingore-names` argument.

Closes #5050

## Test Plan

Added new tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomasdezeeuw Thomasdezeeuw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider ignore-names in all pep8 naming rules astral-sh/ruff
2 participants
@charliermarsh @Thomasdezeeuw