Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle trailing newline as per black for Jupyter notebooks #5190

Closed
Tracked by #5188
dhruvmanila opened this issue Jun 19, 2023 · 0 comments · Fixed by #5202
Closed
Tracked by #5188

Handle trailing newline as per black for Jupyter notebooks #5190

dhruvmanila opened this issue Jun 19, 2023 · 0 comments · Fixed by #5202
Assignees
@dhruvmanila
Labels
core Related to core functionality

Comments

@dhruvmanila
Copy link
Member

dhruvmanila commented Jun 19, 2023 •
edited
Loading

Trailing newline at the end of JSON string is handled separated in black implementation:

https://github.com/psf/black/blob/e7783e9ab27e95cd9b50c2ef84174f4e1c9d60cd/src/black/__init__.py#L1024
@dhruvmanila dhruvmanila mentioned this issue Jun 19, 2023
Closed
26 tasks
@dhruvmanila dhruvmanila added the core Related to core functionality label Jun 19, 2023
@dhruvmanila dhruvmanila mentioned this issue Jun 20, 2023
Merged
@dhruvmanila dhruvmanila self-assigned this Jun 20, 2023
dhruvmanila added a commit that referenced this issue Jun 20, 2023
@dhruvmanila
Handle trailing newline in Jupyter notebook JSON string (#5202)
062b6e5 
## Summary

Handle trailing newline in Jupyter Notebook JSON string similar to how
`black`
does it.

## Test Plan

Add test cases when the JSON string for notebook ends with and without a
newline.

resolves: #5190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
core Related to core functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle trailing newline in Jupyter notebook JSON string astral-sh/ruff
1 participant
@dhruvmanila