Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecosystem CI check links should use permalinks #5702

Closed
charliermarsh opened this issue Jul 12, 2023 · 1 comment · Fixed by #5704
Closed

Ecosystem CI check links should use permalinks #5702

charliermarsh opened this issue Jul 12, 2023 · 1 comment · Fixed by #5704
Labels
internal An internal refactor or improvement

Comments

@charliermarsh
Copy link
Member

I notice that one of the Airflow links pointed to an irrelevant line of code. I'm guessing that the code changed between the ecosystem CI run and my clicking through. Could we instead use permalinks, so that they point to the relevant violations in perpetuity? (Is that even possible?)
@charliermarsh charliermarsh added the internal An internal refactor or improvement label Jul 12, 2023
@dhruvmanila
Copy link
Member

Yeah, it should be possible. We just need to get the current commit hash at the time of checkout.

@dhruvmanila dhruvmanila self-assigned this Jul 12, 2023
@zanieb zanieb mentioned this issue Jul 12, 2023
Merged
@dhruvmanila dhruvmanila removed their assignment Jul 12, 2023
zanieb added a commit that referenced this issue Jul 12, 2023
@zanieb
Use permalinks in ecosystem diff references (#5704)
33a9177 
Closes #5702
konstin pushed a commit that referenced this issue Jul 19, 2023
@zanieb @konstin
Use permalinks in ecosystem diff references (#5704)
0317ee1 
Closes #5702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use permalinks in ecosystem diff references astral-sh/ruff
2 participants
@charliermarsh @dhruvmanila