Formatter: Break quality check before breaking parentheses

[konstin]

We need to change the breaking priorities with equality checks and parentheses:

black:

def f():
    return (
        unicodedata.normalize("NFKC", s1).casefold()
        == unicodedata.normalize("NFKC", s2).casefold()
    )

ct_match = (
    aaaaaaaaaaact_id == self.get_content_type(obj=rel_obj, using=instance._state.db).id
)

ours:

def f():
    return unicodedata.normalize("NFKC", s1).casefold() == unicodedata.normalize(
        "NFKC", s2
    ).casefold()

ct_match = aaaaaaaaaaact_id == self.get_content_type(
    obj=rel_obj, using=instance._state.db
).id

[MichaReiser]

There could be two possible solutions for this

• Either can_omit_parentheses incorrectly returns false
  Or call expressions should not use parenthesized (which gives them a higher priority)

Or it's something entirely different

We may want to rename the issue. This is specific to call expressions. Lists, tuples should have a higher priority

[charliermarsh]

This is pretty specific -- it seems like it has to be a comparator, with a call on either side, and without another parenthesized node? E.g., Black formats this:

ct_match = (
    {aaaaaaaaaaaaaaaa} == self.get_content_type(obj=rel_obj, using=instance._state.db).id
)

As:

ct_match = {aaaaaaaaaaaaaaaa} == self.get_content_type(
    obj=rel_obj, using=instance._state.db
).id