Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: ruff rule shows PLR6301 as non-preview #7804

Closed
jamesbraza opened this issue Oct 4, 2023 · 0 comments · Fixed by #7812
Closed

Bug: ruff rule shows PLR6301 as non-preview #7804

jamesbraza opened this issue Oct 4, 2023 · 0 comments · Fixed by #7812
Assignees
@charliermarsh
Labels
bug Something isn't working cli Related to the command-line interface

Comments

@jamesbraza
Copy link
Contributor

With ruff==0.0.292, it seems PLR6301 from ruff rule --all --format=json has "preview": False. I think it should be True per https://docs.astral.sh/ruff/rules/no-self-use/

This rule is unstable and in preview.
@charliermarsh charliermarsh added bug Something isn't working cli Related to the command-line interface labels Oct 4, 2023
@charliermarsh charliermarsh self-assigned this Oct 4, 2023
@charliermarsh charliermarsh mentioned this issue Oct 4, 2023
Merged
charliermarsh added a commit that referenced this issue Oct 4, 2023
@charliermarsh
Consider nursery rules to be in-preview for ruff rule (#7812)
a0c846f 
## Summary

We treat these rules as `preview` elsewhere, so adding `preview: false`
to the JSON and such seems like an error.

Closes #7804.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider nursery rules to be in-preview for ruff rule astral-sh/ruff
2 participants
@charliermarsh @jamesbraza