Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-assigning-variable (PLW0127) false negative on multi assignment #8667

Closed
DetachHead opened this issue Nov 14, 2023 · 4 comments · Fixed by #8839
Closed

self-assigning-variable (PLW0127) false negative on multi assignment #8667

DetachHead opened this issue Nov 14, 2023 · 4 comments · Fixed by #8839
Assignees
@charliermarsh
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DetachHead
Copy link 

a = 1
a = a # error

b = b = 1 # no error

playground
@charliermarsh
Copy link
Member

Should the issue title be "false negative"? I want to make sure I understand the issue.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 14, 2023
@DetachHead DetachHead changed the title self-assigning-variable (PLW0127) false positive on multi assignment self-assigning-variable (PLW0127) negative positive on multi assignment Nov 14, 2023
@DetachHead
Copy link
Author

yeah my bad

@DetachHead DetachHead changed the title self-assigning-variable (PLW0127) negative positive on multi assignment self-assigning-variable (PLW0127) false negative on multi assignment Nov 14, 2023
@charliermarsh
Copy link
Member

No worries, thanks!

@charliermarsh charliermarsh added the good first issue Good for newcomers label Nov 14, 2023
@DetachHead
Copy link
Author

if this is a good first issue Good for newcomers i'll have a go at fixing it myself

@charliermarsh charliermarsh self-assigned this Nov 25, 2023
@charliermarsh charliermarsh mentioned this issue Nov 25, 2023
Merged
charliermarsh added a commit that referenced this issue Nov 25, 2023
@charliermarsh
[pylint] Extend self-assigning-variable to multi-target assignmen…
9b17724 
…ts (#8839)

Closes #8667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pylint] Extend self-assigning-variable to multi-target assignments astral-sh/ruff
2 participants
@charliermarsh @DetachHead