Incorrect ANN201 autofix

[hauntsaninja]

Given:

from somewhere import get_cfg

def lookup_cfg(cfg_description):
    cfg = get_cfg(cfg_description)
    if cfg is not None:
        return cfg
    raise AttributeError(f"No cfg found matching {cfg_description}")

ANN201 suggests the following incorrect fix:

λ ruff check --select=ANN2 x.py --fix --unsafe-fixes --diff
--- x.py
+++ x.py
@@ -1,6 +1,7 @@
 from somewhere import get_cfg
+from typing import Never
 
-def lookup_cfg(cfg_description):
+def lookup_cfg(cfg_description) -> Never:
     cfg = get_cfg(cfg_description)
     if cfg is not None:
         return cfg

Would fix 1 error.

[hauntsaninja]

Presumably relates to #9206

[hauntsaninja]

Thanks! :-)

[hauntsaninja]

I think the behaviour still isn't quite right:

λ cat xx.py
def foo(a):
    if a > 5:
        raise ValueError("oops")
    else:
        print("nope")
λ ruff --version
ruff 0.1.11
λ ruff check xx.py --select=ANN2 --fix --unsafe-fixes --diff
--- xx.py
+++ xx.py
@@ -1,4 +1,5 @@
-def foo(a):
+from typing import Never
+def foo(a) -> Never:
     if a > 5:
         raise ValueError("oops")
     else:

Would fix 1 error.

[charliermarsh]

🤦 One more try...