[pygrep-hooks] Improve blanket-noqa error message (PGH004)
#10851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustelalande
force-pushed
the
improve-pgh004
branch
from
4f6156a to
57324c5
Compare
|
charliermarsh
force-pushed
the
improve-pgh004
branch
from
5dd7538 to
fb64d60
Compare
charliermarsh
force-pushed
the
improve-pgh004
branch
from
fb64d60 to
fcc872c
Compare
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 12, 2024
…ral-sh#10851) ## Summary Improve `blanket-noqa` error message in cases where codes are provided but not detected due to formatting issues. Namely `# noqa X100` (missing colon) or `noqa : X100` (space before colon). The behavior is similar to `NQA002` and `NQA003` from `flake8-noqa` mentioned in astral-sh#850. The idea to merge the rules into `PGH004` was suggested by @MichaReiser astral-sh#10325 (comment). ## Test Plan Test cases added to fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve
blanket-noqaerror message in cases where codes are provided but not detected due to formatting issues. Namely# noqa X100(missing colon) ornoqa : X100(space before colon). The behavior is similar toNQA002andNQA003fromflake8-noqamentioned in #850. The idea to merge the rules intoPGH004was suggested by @MichaReiser #10325 (comment).Test Plan
Test cases added to fixture.