Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining tests to new framework #10856

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

dhruvmanila
Copy link
Member

Summary

This PR moves the remaining tests to the resources directory. The reason this was remaining is because it's all mainly with item tests which I was working on at that moment. I've removed duplicate test cases and moved only the unique ones.

@dhruvmanila dhruvmanila added parser Related to the parser testing Related to testing Ruff itself labels Apr 10, 2024
@dhruvmanila dhruvmanila merged commit 8c2c599 into dhruv/parser Apr 10, 2024
5 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/move-tests branch April 10, 2024 04:20
Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #10856 will degrade performances by 5.78%

Comparing dhruv/move-tests (4cf084b) with dhruv/parser (38d649c)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark dhruv/parser dhruv/move-tests Change
parser[large/dataset.py] 28.7 ms 26.7 ms +7.66%
parser[pydantic/types.py] 11.8 ms 10.9 ms +8.19%
parser[unicode/pypinyin.py] 1.6 ms 1.7 ms -5.78%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila added a commit that referenced this pull request Apr 11, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
dhruvmanila added a commit that referenced this pull request Apr 15, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
dhruvmanila added a commit that referenced this pull request Apr 17, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
dhruvmanila added a commit that referenced this pull request Apr 18, 2024
## Summary

This PR moves the remaining tests to the resources directory. The reason
this was remaining is because it's all mainly with item tests which I
was working on at that moment. I've removed duplicate test cases and
moved only the unique ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Related to the parser testing Related to testing Ruff itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant