Build a separate ARM wheel for macOS #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/arm
branch
from
8c8abfc to
f0886d4
Compare
konstin
approved these changes
Apr 25, 2024
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
Apr 25, 2024
## Summary See: astral-sh/ruff#11149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we already build an x86 wheel, we can just build an ARM wheel rather than cross-compiling to universal.
The build time is ~3 minutes vs. > 20 minutes and the resulting artifact is much smaller, which is also a win for users.