Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate unicode-width to v0.1.13 #11194

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 29, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
unicode-width workspace.dependencies patch 0.1.11 -> 0.1.13

Release Notes

unicode-rs/unicode-width (unicode-width)

v0.1.13

Compare Source

v0.1.12

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the internal An internal refactor or improvement label Apr 29, 2024
@MichaReiser
Copy link
Member

So, in theory, this is a breaking change because it changes how the character width is measured in the formatter. But then, I think keeping up to date with the unicode spec makes sense

@MichaReiser
Copy link
Member

I'm not quiet sure why the output changes but annotation snippted (the crate we use for rendering code frames) uses text width.

@MichaReiser MichaReiser added this to the v0.5.0 milestone May 30, 2024
@renovate renovate bot force-pushed the renovate/unicode-width-0.x-lockfile branch from f654a40 to a9db3c9 Compare June 4, 2024 19:16
@renovate renovate bot changed the title Update Rust crate unicode-width to v0.1.12 Update Rust crate unicode-width to v0.1.13 Jun 4, 2024
@renovate renovate bot force-pushed the renovate/unicode-width-0.x-lockfile branch from a9db3c9 to 2ba346b Compare June 8, 2024 06:25
@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 12:12
@MichaReiser MichaReiser added breaking Breaking API change and removed internal An internal refactor or improvement labels Jun 24, 2024
@MichaReiser MichaReiser force-pushed the renovate/unicode-width-0.x-lockfile branch from 38007cd to a8d2473 Compare June 24, 2024 12:15
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser merged commit 9348821 into ruff-0.5 Jun 24, 2024
20 checks passed
@MichaReiser MichaReiser deleted the renovate/unicode-width-0.x-lockfile branch June 24, 2024 12:37
@MichaReiser MichaReiser mentioned this pull request Jun 26, 2024
MichaReiser added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micha Reiser <micha@reiser.io>
MichaReiser added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micha Reiser <micha@reiser.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant