Upgrade to Rust 1.78 #11260
Merged
Upgrade to Rust 1.78 #11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
commented
May 3, 2024
| /// no comments are dropped. | ||
| /// | ||
| /// A node can have dangling comments if all its children are tokens or if all node children are optional. | ||
| fn fmt_dangling_comments( |
There was a problem hiding this comment.
The function was never called, 🤭
I decided to instead inline the debug_assertion in fmt and test that all dangling comments were formatted.
|
dhruvmanila
approved these changes
May 3, 2024
AlexWaygood
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets the local toolchain to 1.78. This PR does not update the minimal required rust version.
Test Plan
cargo test